Complete settings

Please also review the wiki section https://wikis.uni-paderborn.de/pgandi/Routing_Protocol_Evaluations#Database_Application which discuss why these settings were chosen.

Review !86 (merged) first.

SonarQube analysis reported 7 issues

• ⛔ 1 blocker
• 🚫 3 critical
• 🔽 3 minor

1. ⛔ Add some tests to this class. 📘
2. 🚫 Make this class "Serializable". 📘
3. 🚫 Make this class "Serializable". 📘
4. 🚫 Make this class "Serializable". 📘
5. 🔽 Drop this interface in favor of "java.util.function.BiFunction<Collection,List,Collection>". 📘
6. 🔽 Add a 'package-info.java' file to document the 'choosers' package 📘
7. 🔽 Add a 'package-info.java' file to document the 'prioritizers' package 📘

SonarQube analysis reported 7 issues

• ⛔ 1 blocker
• 🚫 3 critical
• 🔽 3 minor

1. ⛔ Add some tests to this class. 📘
2. 🚫 Make this class "Serializable". 📘
3. 🚫 Make this class "Serializable". 📘
4. 🚫 Make this class "Serializable". 📘
5. 🔽 Drop this interface in favor of "java.util.function.BiFunction<Collection,List,Collection>". 📘
6. 🔽 Add a 'package-info.java' file to document the 'choosers' package 📘
7. 🔽 Add a 'package-info.java' file to document the 'prioritizers' package 📘

SonarQube analysis reported 18 issues

• ⛔ 1 blocker
• 🚫 3 critical
• ⚠ 1 major
• 🔽 13 minor

1. ⛔ Add some tests to this class. 📘
2. 🚫 Make this class "Serializable". 📘
3. 🚫 Make this class "Serializable". 📘
4. 🚫 Make this class "Serializable". 📘
5. ⚠ Assign this magic number 2 to a well-named constant, and use the constant instead. 📘
6. 🔽 Drop this interface in favor of "java.util.function.BiFunction<Collection,List,Collection>". 📘
7. 🔽 Make this line start at column 13. 📘
8. 🔽 Define the locale to be used in this String operation. 📘
9. 🔽 Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call. 📘
10. 🔽 Make this line start at column 17. 📘
11. 🔽 Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call. 📘
12. 🔽 Make this line start at column 17. 📘
13. 🔽 Make this line start at column 17. 📘
14. 🔽 Make this line start at column 21. 📘
15. 🔽 Move this "else" on the same line that the previous closing curly brace. 📘
16. 🔽 Make this line start at column 13. 📘
17. 🔽 Add a 'package-info.java' file to document the 'choosers' package 📘
18. 🔽 Add a 'package-info.java' file to document the 'prioritizers' package 📘

added 112 commits

• 9bab4330...3cab61ae - 111 commits from branch master
• 41b62f1d - Merge remote-tracking branch 'remotes/origin/master' into feature-#318-complete-settings

Compare with previous version

SonarQube analysis reported no issues.

added 73 commits

• 41b62f1d...4e3b775a - 72 commits from branch master
• 90d2da6a - Merge remote-tracking branch 'remotes/origin/master' into feature-#318-complete-settings

Compare with previous version

added Needs Review label

changed the description

SonarQube analysis reported no issues.

resolved all discussions

added Needs information from dev and removed Needs Review labels

added Needs information from reviewer and removed Needs information from dev labels

resolved all discussions

merged

mentioned in commit a5b7ebd3