Last tests for router

Add missing tests.

Review !85 (merged), !78 (merged), !77 (merged) first.

SonarQube analysis reported 8 issues

• ⛔ 1 blocker
• 🚫 3 critical
• 🔽 4 minor

1. ⛔ Add some tests to this class. 📘
2. 🚫 Make this class "Serializable". 📘
3. 🚫 Make this class "Serializable". 📘
4. 🚫 Make this class "Serializable". 📘
5. 🔽 Drop this interface in favor of "java.util.function.BiFunction<Collection,List,Collection>". 📘
6. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘
7. 🔽 Add a 'package-info.java' file to document the 'choosers' package 📘
8. 🔽 Add a 'package-info.java' file to document the 'prioritizers' package 📘

SonarQube analysis reported 8 issues

• ⛔ 1 blocker
• 🚫 3 critical
• 🔽 4 minor

1. ⛔ Add some tests to this class. 📘
2. 🚫 Make this class "Serializable". 📘
3. 🚫 Make this class "Serializable". 📘
4. 🚫 Make this class "Serializable". 📘
5. 🔽 Drop this interface in favor of "java.util.function.BiFunction<Collection,List,Collection>". 📘
6. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘
7. 🔽 Add a 'package-info.java' file to document the 'choosers' package 📘
8. 🔽 Add a 'package-info.java' file to document the 'prioritizers' package 📘

mentioned in merge request !89 (merged)

added 87 commits

• ec8ee670...310566a5 - 86 commits from branch master
• f55a53fb - Merge remote-tracking branch 'remotes/origin/master' into feature-#306-complete-router

Compare with previous version

SonarQube analysis reported no issues.

added 1 commit

• 2cad8dad - Repair wrong merge

Compare with previous version

added Needs Review label

SonarQube analysis reported no issues.

assigned to @amaehrle

changed the description

added Needs Changes Needs information from dev and removed Needs Review labels

added 3 commits

• 24ad6ff9 - Use fallthrough in switch-case
• 4687774e - Add more comments
• fb8294be - Add comments about rating increasements

Compare with previous version

added Needs Review and removed Needs Changes Needs information from dev labels

SonarQube analysis reported no issues.

added Needs Changes Needs information from dev and removed Needs Review labels

added 2 commits

• 00676b2e - Improve comments
• 11495b3a - Add more asserts

Compare with previous version

added Needs Review and removed Needs Changes Needs information from dev labels

SonarQube analysis reported 5 issues

• 🔽 5 minor

1. 🔽 Move this trailing comment on the previous empty line. 📘
2. 🔽 Replace the type specification in this constructor call with the diamond operator ("<>"). 📘
3. 🔽 Move this trailing comment on the previous empty line. 📘
4. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
5. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

resolved all discussions

merged

mentioned in commit 4e3b775a