Feature #338 dont copy message paths

SonarQube analysis reported no issues.

added Needs Review label

added Needs Changes and removed Needs Review labels

added 1 commit

• 00ffe8bb - Turn message path copying into a setting (no hop count yet)

Compare with previous version

assigned to @bheymann

added 1 commit

• e9396c24 - Calculate hop count

Compare with previous version

added 1 commit

• 73c8d8c1 - No longer exclude tests as default setting makes them pass

Compare with previous version

added Needs Review and removed Needs Changes labels

added 128 commits

• 73c8d8c1...3cab61ae - 127 commits from branch master
• 805d5a08 - Merge branch 'master' into feature-#338-dont-copy-message-paths

Compare with previous version

SonarQube analysis reported 5 issues

• ⚠ 1 major
• 🔽 4 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Make this "public static storeFullMsgPath" field final 📘
3. 🔽 Make storeFullMsgPath a static final constant or non-public and provide accessors if needed. 📘
4. 🔽 Move this constructor to comply with Java Code Conventions. 📘
5. 🔽 Move this constructor to comply with Java Code Conventions. 📘

added Needs Changes and removed Needs Review labels

added 1 commit

• 59e0af84 - Rename and comment setting of path copying for better comprehension

Compare with previous version

added 1 commit

• 4fbf46f2 - Decrease visibility for storeFullMsgPath

Compare with previous version

SonarQube analysis reported 5 issues

• ⚠ 1 major
• 🔽 4 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Make this "public static storeFullMsgPath" field final 📘
3. 🔽 Make storeFullMsgPath a static final constant or non-public and provide accessors if needed. 📘
4. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
5. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

SonarQube analysis reported 3 issues

• ⚠ 1 major
• 🔽 2 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
3. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

added 1 commit

• 428f6353 - Use hopcount not path.size for copying since we might not have a path

Compare with previous version

SonarQube analysis reported 3 issues

• ⚠ 1 major
• 🔽 2 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
3. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

added 1 commit

• eb7d7bd9 - Only add nodes to path list if we are storing the path

Compare with previous version

SonarQube analysis reported 3 issues

• ⚠ 1 major
• 🔽 2 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
3. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

added 1 commit

• f8eeee36 - Add tests for new setting for storing full message path

Compare with previous version

SonarQube analysis reported 3 issues

• ⚠ 1 major
• 🔽 2 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
3. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

added 1 commit

• c2a8b526 - Test hop count is correct with and without message path

Compare with previous version

SonarQube analysis reported 3 issues

• ⚠ 1 major
• 🔽 2 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
3. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

added Needs Review and removed Needs Changes labels

added Needs Changes and removed Needs Review labels

added 1 commit

• e9ac78e0 - Simplify code

Compare with previous version

added Needs Review label

removed Needs Changes label

SonarQube analysis reported 7 issues

• ⚠ 1 major
• 🔽 6 minor

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Move this trailing comment on the previous empty line. 📘
5. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘
6. 🔽 Move the declaration of "occupancy" closer to the code that uses it. 📘
7. 🔽 Immediately return this expression instead of assigning it to the temporary variable "m". 📘

Overall: Please merge in the master.

added Needs Changes and removed Needs Review labels

added 1 commit

• b2da0d7b - Add documentation to transferMessage and getHopCountForMsgInCollection

Compare with previous version

resolved all discussions

added 99 commits

• b2da0d7b...3d2e9a4c - 98 commits from branch master
• 733182a8 - Merge branch 'master' into feature-#338-dont-copy-message-paths

Compare with previous version

SonarQube analysis reported 1 issue

• ⚠ 1 major

1. ⚠ class "Message" has 36 methods, which is greater than the 35 authorized. Split it into smaller classes. 📘

added Needs information from dev and removed Needs Changes labels

removed Needs information from dev label

merged

mentioned in commit 3bfe83bf