Feature #325 cache ordered messages for connected
Review !79 (merged) first
Merge request reports
Activity
SonarQube analysis reported 9 issues
-
⚠ 1 major -
🔽 8 minor
-
⚠ Change this comparison to use the equals method.📘 -
🔽 Make this line start at column 9.📘 -
🔽 Make this line start at column 13.📘 -
🔽 Make this final field static too.📘 -
🔽 Rename this field "DEFAULT_ORDERING_INTERVAL" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.📘 -
🔽 Return a copy of "cachedMessagesForConnected".📘 -
🔽 Make this line start at column 13.📘 -
🔽 Make this line start at column 9.📘 -
🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG📘
-
added 1 commit
- 5f111072 - Use cached messages for requestDeliverableMessaes
SonarQube analysis reported 11 issues
-
⚠ 2 major -
🔽 9 minor
-
⚠ Remove this useless assignment to local variable "other".📘 -
⚠ Change this comparison to use the equals method.📘 -
🔽 Make this line start at column 9.📘 -
🔽 Make this line start at column 13.📘 -
🔽 Make this final field static too.📘 -
🔽 Rename this field "DEFAULT_ORDERING_INTERVAL" to match the regular expression '^[a-z][a-zA-Z0-9]*$'.📘 -
🔽 Remove this unused "other" local variable.📘 -
🔽 Return a copy of "cachedMessagesForConnected".📘 -
🔽 Make this line start at column 13.📘 -
🔽 Make this line start at column 9.📘 -
🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG📘
-
added 1 commit
- f5c38d8d - Fix SonarQube issues and reuse method reorderMessagesForConnected
SonarQube analysis reported 5 issues
-
⚠ 1 major -
🔽 4 minor
-
⚠ Change this comparison to use the equals method.📘 -
🔽 Make this line start at column 9.📘 -
🔽 Make this line start at column 13.📘 -
🔽 Return a copy of "cachedMessagesForConnected".📘 -
🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG📘
-
added 31 commits
-
f5c38d8d...9356d146 - 12 commits from branch
master
- 45f2e4a6 - Make default ordering interval static and set it to 0.0
- 82196c56 - Set default ordering interval for our scenario to 2.0
- 9451d2cc - Set initial value to lastMessageOrdering to Double.MIN_VALUE
- 3e6d9687 - Fix indentation for getMessageOrderingInterval
- f7e31a45 - Revert accidentally replacing fixed time by messageOrderingInterval
- abb30568 - Remove message ordering interval from EpidemicRouterTest
- d7644359 - Remove unused import of ActiveRouter
- 12177e31 - Remove message ordering interval from ProphetRouterTest
- 16655451 - Reorder messages if the router has messages but they are not cached
- b23c5438 - Fix indentation
- a96b5235 - Add first test for message ordering interval
- 1d745c60 - Fix indentation
- 601e64cb - Add new queue mode to MessageRouter: Highest priority first
- 77256378 - Move setting of sendQueueMode to separate method to reduce complexity
- b94b9dfb - Merge branch 'feature-#325-queue-mode-prio' into feature-#325-cache-ordered-messages
- 11e7e685 - Order messages by priority descending instead of ascending
- cb88becc - Merge branch 'feature-#325-queue-mode-prio' into feature-#325-cache-ordered-messages
- 77c5c1cb - Add test for message ordering interval
- 1526bd3f - Merge branch 'feature-#325-cache-ordered-messages' into feature-#325-cache-order…
Toggle commit list-
f5c38d8d...9356d146 - 12 commits from branch
SonarQube analysis reported 4 issues
-
⚠ 1 major -
🔽 3 minor
-
added 21 commits
-
1526bd3f...11b66319 - 20 commits from branch
master
- be7daa39 - Merge branch 'master' into feature-#325-cache-ordered-messages-for-connected
-
1526bd3f...11b66319 - 20 commits from branch
SonarQube analysis reported 5 issues
-
⚠ 1 major -
🔽 4 minor
-
added 17 commits
-
be7daa39...17fa1262 - 16 commits from branch
master
- 54d56c3e - Merge branch 'master' into feature-#325-cache-ordered-messages-for-connected
-
be7daa39...17fa1262 - 16 commits from branch
added 1 commit
- a88d4905 - Do not use ListIterator (we are not using cachedMessages while deleting)
added Needs Review label
added Needs Changes and removed Needs Review labels
added 1 commit
- 5c7bdd0c - Add test for message ordering for final deliveries
SonarQube analysis reported 2 issues
-
🔽 2 minor
-
added 1 commit
- 808213bc - Fix: Remove messages to connected from actual messagesToConnected
SonarQube analysis reported 2 issues
-
🔽 2 minor
-
added 1 commit
- ae3981fe - Add comments what is happening in the time check
SonarQube analysis reported 2 issues
-
🔽 2 minor
-
added 1 commit
- 720f6f79 - Set lastMessageOrderingFC to -inf so we initially order messages
added 1 commit
- d46183c2 - Adapt test for message ordering so it fails when we don't initially order
SonarQube analysis reported 2 issues
-
🔽 2 minor
-
SonarQube analysis reported 2 issues
-
🔽 2 minor
-
added 27 commits
-
d46183c2...cd299f0f - 26 commits from branch
master
- 0a2ad807 - Merge branch 'master' into 'feature-#325-cache-ordered-messages-for-connected'
-
d46183c2...cd299f0f - 26 commits from branch
SonarQube analysis reported 3 issues
-
⚠ 1 major -
🔽 2 minor
-
added 1 commit
- f29a5609 - Use getSortedMessagesForConnected for reordering in correct intervals
SonarQube analysis reported 3 issues
-
🔽 1 minor -
ℹ 2 info
-
added 1 commit
- 33a26b0b - Improve readability of requestDeliverableMessages
SonarQube analysis reported 3 issues
-
🔽 1 minor -
ℹ 2 info
-
added Needs Review and removed Needs Changes labels
mentioned in commit 3cab61ae
mentioned in merge request !117 (merged)