Feature #330: Improve runtime for InterferenceLimitedInterface.update()

This MR includes

• Fixing the settings file for scanInterval
• Splitting up InterferenceLimitInterface.update into multiple methods to see which costs most performance

SonarQube analysis reported 1 issue

• 🔽 1 minor

1. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 1 issue

• 🔽 1 minor

1. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 1 issue

• 🔽 1 minor

1. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 2 issues

• ⚠ 1 major
• 🔽 1 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 2 issues

• ⚠ 1 major
• 🔽 1 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 4 issues

• ⚠ 1 major
• 🔽 3 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 4 issues

• ⚠ 1 major
• 🔽 3 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 4 issues

• ⚠ 1 major
• 🔽 3 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 4 issues

• ⚠ 1 major
• 🔽 3 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 4 issues

• ⚠ 1 major
• 🔽 3 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

SonarQube analysis reported 4 issues

• ⚠ 1 major
• 🔽 3 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG 📘

added Needs Review label

Why did you change this from !isConnected to isActive()? Please open another MR for this if this is a separate logic change. (Pretty much hidden in refactoring right now).

It's not we check still check isConnected(anotherInterface).

I changed anotherInterface.getHost.isRadioActive to anotherInterface.isActive, i.e., we only connect to an interface if it's active, not if any interface of the host is active. This doesn't change behaviour for us at all, but I don't see how the previous behaviour made sense.

I moved isScanning out of this method, so I do not check it for every potential connection, just once for all. But the check is still done at the same time, we do not make more or less connections.

You're right on account of isScanning. I agree with the isActive reasoning, but it is still a separate logical change I would like to see a separate MR on.

Okay, moved to !91 (merged)

added Needs information from dev and removed Needs Review labels

SonarQube analysis reported 4 issues

• ⚠ 1 major
• 🔽 3 minor

1. ⚠ Change this comparison to use the equals method. 📘
2. 🔽 Make this line start at column 9. 📘
3. 🔽 Make this line start at column 13. 📘
4. 🔽 Make this line start at column 13. 📘

SonarQube analysis reported 3 issues

• 🔽 3 minor

1. 🔽 Make this line start at column 9. 📘
2. 🔽 Make this line start at column 13. 📘
3. 🔽 Make this line start at column 13. 📘

SonarQube analysis reported 1 issue

• 🔽 1 minor

1. 🔽 Make this line start at column 13. 📘

SonarQube analysis reported no issues.

added 5 commits

• 178b0374 - Do not use iterator for removing sending connections
• 082f237a - Use equals instead of == for comparison
• 083de938 - Change removeConnection access to private and fix indentation in it
• ed68eb71 - Fix indentation
• 7c457511 - Merge branch 'feature-#328-iterators-instead-of-list-copies' into feature-#330-improve-update

Compare with previous version

added Needs Review and removed Needs information from dev labels

SonarQube analysis reported no issues.

added Needs Changes and removed Needs Review labels

added 61 commits

• 7c457511...11b66319 - 59 commits from branch master
• 6fff1cc9 - Merge branch 'master' into feature-#330-improve-update
• a9ea68d4 - Remove iterators from rejected MR

Compare with previous version

changed the description

SonarQube analysis reported no issues.

mentioned in merge request !91 (merged)

added Needs Review and removed Needs Changes labels

merged

mentioned in commit 1b8abd6e