Fix some SonarLint issues

refs #40

parent 109488d4

No related branches found

No related tags found

1 merge request!8WIP: Broadcast messages in application layer

Pipeline #

Hide whitespace changes

Inline Side-by-side

Showing with 74 additions and 78 deletions

Ghost User @ghost · 8 years ago

Contributor
SonarQube analysis reported 5 issues:

1 critical

3 major

1 minor

Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this commit:

Remove usage of generic wildcard type.

Drop this interface in favor of "java.util.function.Supplier".

Remove this unused "toReceivePolicy" private field.

Remove this unused "fromReceivePolicy" private field.

Rename this abstract class name to match the regular expression '^Abstract[A-Z][a-zA-Z0-9]*$'.

SonarQube analysis reported 5 issues: * ![CRITICAL](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-critical.png) 1 critical * ![MAJOR](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-major.png) 3 major * ![MINOR](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-minor.png) 1 minor Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this commit: * ![CRITICAL](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-critical.png) [Remove usage of generic wildcard type.](https://git.cs.upb.de/pg-andi/Simulator/blob/f01a56794c32d0bef4ecce447f93afad407bd700/src/routing/ActiveRouter.java#L381) [![rule](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/rule.png)](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1452) * ![MAJOR](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-major.png) [Drop this interface in favor of "java.util.function.Supplier<List>".](https://git.cs.upb.de/pg-andi/Simulator/blob/f01a56794c32d0bef4ecce447f93afad407bd700/src/core/ISpecificRecipientsMessage.java#L11) [![rule](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/rule.png)](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1711) * ![MAJOR](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-major.png) [Remove this unused "toReceivePolicy" private field.](https://git.cs.upb.de/pg-andi/Simulator/blob/f01a56794c32d0bef4ecce447f93afad407bd700/src/routing/util/MessageTransferAcceptPolicy.java#L119) [![rule](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/rule.png)](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1068) * ![MAJOR](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-major.png) [Remove this unused "fromReceivePolicy" private field.](https://git.cs.upb.de/pg-andi/Simulator/blob/f01a56794c32d0bef4ecce447f93afad407bd700/src/routing/util/MessageTransferAcceptPolicy.java#L120) [![rule](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/rule.png)](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1068) * ![MINOR](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/severity-minor.png) [Rename this abstract class name to match the regular expression '^Abstract[A-Z][a-zA-Z0-9]*$'.](https://git.cs.upb.de/pg-andi/Simulator/blob/f01a56794c32d0bef4ecce447f93afad407bd700/src/core/Message.java#L16) [![rule](https://gitlab.talanlabs.com/gabriel-allaigre/sonar-gitlab-plugin/raw/master/images/rule.png)](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS00118)

Please register or to comment