Next improvements according to Britta's review

toolkit/reportSummary/energyAnalysis.py

@@ -60,14 +60,13 @@ class EnergyData:
         self.currentTotalHosts += 1
         if energyLevel < 0.1:
             self.currentHostsThatEverReachedLowEnergyLimit.add(host)
-            if(energyLevel == 0 ):
-                # Draws two functions over the same x values.
+            if energyLevel == 0:
                 self.currentHostsThatEverReachedZeroEnergy.add(host)
                 self.currentZeroEnergyHosts += 1
             else:
                 self.currentLowEnergyHosts += 1
 
-# Draws two functions over the same x values.
+# Draws the four functions over the same x values.
 # Labels are selected as appropriate for energy analysis.
 # In the end saves the plot
 def drawAndSafePlots(x, y_lowEnergy, y_noEnergy, y_totalLowEnergy, y_totalNoEnergy, graphicFileName):

[Ghost User]

SonarQube analysis reported 13 issues

• ⚠ 1 major
• 🔽 12 minor

1. ⚠ Equality tests should not be made with floating point values. 📘
2. 🔽 Replace the type specification in this constructor call with the diamond operator ("<>"). 📘
3. 🔽 Make this line start at column 9. 📘
4. 🔽 Make this line start at column 9. 📘
5. 🔽 Move this trailing comment on the previous empty line. 📘
6. 🔽 Make this line start at column 13. 📘
7. 🔽 Move this "else" on the same line that the previous closing curly brace. 📘
8. 🔽 Make this line start at column 13. 📘
9. 🔽 Make this line start at column 13. 📘
10. 🔽 Move this "else" on the same line that the previous closing curly brace. 📘
11. 🔽 Make this line start at column 17. 📘
12. 🔽 Move this "else" on the same line that the previous closing curly brace. 📘
13. 🔽 Make this line start at column 17. 📘