Revert deletion of some classes

src/input/BroadcastEventGenerator.java

+package input;
+
+import core.Settings;
+
+/**
+ * Broadcast creation external events generator. Creates uniformly distributed
+ * broadcast creation patterns whose message size and inter-message intervals can
+ * be configured.
+ *
+ * Created by Britta Heymann on 22.02.2017.
+ */
+public class BroadcastEventGenerator extends AbstractMessageEventGenerator {
+    public BroadcastEventGenerator(Settings s) {
+        super(s, true);
+    }
+
+    /**
+     * Returns the next broadcast creation event.
+     * @see EventQueue#nextEvent()
+     */
+    @Override
+    public ExternalEvent nextEvent() {
+        /* Message is a one way message */
+        int responseSize = 0;
+
+        /* Draw additional message properties and create message. */
+        int interval = this.drawNextEventTimeDiff();
+        int sender = this.drawHostAddress(this.hostRange);
+        ExternalEvent messageCreateEvent = new BroadcastCreateEvent(
+                sender,
+                this.getID(),
+                this.drawMessageSize(),
+                responseSize,
+                this.nextEventsTime);
+
+        /* Update next event time before returning. */
+        this.advanceToNextEvent(interval);
+        return messageCreateEvent;
+    }
+}

src/test/AbstractMessageEventGeneratorTest.java

+package test;
+
+import input.AbstractMessageEventGenerator;
+import org.junit.Before;
+
+/**
+ * Contains common initialization for both {@link MessageEventGeneratorTest} and {@link BroadcastEventGeneratorTest}.
+ *
+ * Created by Britta Heymann on 22.02.2017.
+ */
+public abstract class AbstractMessageEventGeneratorTest {
+    /**
+     * The number of times a test is repeated for tests that might be non-deterministic.
+     */
+    protected static final int NR_TRIALS_IN_TEST = 10;
+
+    protected TestSettings settings = new TestSettings();
+
+    @Before
+    public void init() {
+        this.settings.putSetting("Events.nrof", "1");
+
+        this.settings.putSetting("class", this.getMessageEventGeneratorClassName());
+        this.settings.putSetting(AbstractMessageEventGenerator.MESSAGE_INTERVAL_S, "1,2");
+        this.settings.putSetting(AbstractMessageEventGenerator.MESSAGE_SIZE_S, "500k,1M");
+        this.settings.putSetting(AbstractMessageEventGenerator.HOST_RANGE_S, "0,126");
+        this.settings.putSetting(AbstractMessageEventGenerator.MESSAGE_ID_PREFIX_S, "M");
+    }
+
+    /**
+     * Gets the class name of the class to generate message events with.
+     */
+    protected abstract String getMessageEventGeneratorClassName();
+}
+

src/test/BroadcastEventGeneratorTest.java

+package test;
+
+import org.junit.Test;
+
+import core.SettingsError;
+
+import input.BroadcastCreateEvent;
+import input.BroadcastEventGenerator;
+import input.AbstractMessageEventGenerator;
+
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Contains tests for the {@link BroadcastEventGenerator} class.
+ * Test set up is handled by the extended {@link AbstractMessageEventGeneratorTest} class.
+ *
+ * Created by Britta Heymann on 22.02.2017.
+ */
+public class BroadcastEventGeneratorTest extends AbstractMessageEventGeneratorTest {
+    @Test
+    public void testNextEventCreatesBroadcastMessages() {
+        AbstractMessageEventGenerator generator = new BroadcastEventGenerator(this.settings);
+        for(int i = 0; i < AbstractMessageEventGeneratorTest.NR_TRIALS_IN_TEST; i++) {
+            assertTrue(
+                    "Event should have been the creation of a broadcast message.",
+                    generator.nextEvent() instanceof BroadcastCreateEvent);
+        }
+    }
+
+    @Test(expected = SettingsError.class)
+    public void testBroadcastEventGeneratorConstructorThrowsErrorIfSingleHostIsSpecified() {
+        this.settings.putSetting(AbstractMessageEventGenerator.HOST_RANGE_S, "0,1");
+        new BroadcastEventGenerator(this.settings);
+    }
+
+    /**
+     * Gets the class name of the class to generate message events with.
+     */
+    @Override
+    protected String getMessageEventGeneratorClassName() {
+        return BroadcastEventGenerator.class.toString();
+    }
+}

[Ghost User]

SonarQube analysis reported 93 issues:

• 3 blocker
• 2 critical
• 25 major
• 59 minor
• 4 info

Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this commit:

• Add some tests to this class.
• Add some tests to this class.
• Add some tests to this class.
• Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
• The Cyclomatic Complexity of this method "MessageEventGenerator" is 11 which is greater than 10 authorized.
• Change this comparison to use the equals method.
• Change this comparison to use the equals method.
• Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.
• Remove this unused private "drawEventRange" method.
• Assign this magic number 2 to a well-named constant, and use the constant instead.
• Assign this magic number 2 to a well-named constant, and use the constant instead.
• Assign this magic number 2 to a well-named constant, and use the constant instead.
• Assign this magic number 2 to a well-named constant, and use the constant instead.
• Convert this usage of the ternary operator to an "if"/"else" structure.
• Convert this usage of the ternary operator to an "if"/"else" structure.
• Convert this usage of the ternary operator to an "if"/"else" structure.
• Convert this usage of the ternary operator to an "if"/"else" structure.
• Assign this magic number 2 to a well-named constant, and use the constant instead.
• Assign this magic number 2 to a well-named constant, and use the constant instead.
• Assign this magic number 2 to a well-named constant, and use the constant instead.
• Catch a list of specific exception subtypes instead.
• Remove the usage of the checked exception 'IOException'.
• Catch a list of specific exception subtypes instead.
• Either log or rethrow this exception.
• This block of commented-out lines of code should be removed.
• This block of commented-out lines of code should be removed.
• This block of commented-out lines of code should be removed.
• This block of commented-out lines of code should be removed.
• This block of commented-out lines of code should be removed.
• Assign this magic number 0.01 to a well-named constant, and use the constant instead.
• Make this line start at column 9.
• Make this line start at column 9.
• Make this line start at column 17.
• Remove this duplicated import.
• Remove this duplicated import.
• Make this line start at column 13.
• Make this line start at column 9.
• Make this line start at column 9.
• Remove this duplicated import.
• Remove this duplicated import.
• Remove this duplicated import.
• Remove this duplicated import.
• Remove this duplicated import.
• Replace all tab characters in this file by sequences of white-spaces.
• Move this "else" on the same line that the previous closing curly brace.
• Make this line start at column 13.
• Move this "else" on the same line that the previous closing curly brace.
• Move this "else" on the same line that the previous closing curly brace.
• Move this "else" on the same line that the previous closing curly brace.
• Move this "else" on the same line that the previous closing curly brace.
• Move the array designator from the variable to the type.
• Make this line start at column 5.
• Make this line start at column 9.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 17.
• Make this line start at column 17.
• Make this line start at column 9.
• Make this line start at column 13.
• Make this line start at column 9.
• Make this line start at column 9.
• Make this line start at column 9.
• Make this line start at column 13.
• Make this line start at column 9.
• Make this line start at column 13.
• Make this line start at column 9.
• Make this line start at column 9.
• Remove this initialization to "0", the compiler will do that for you.
• Remove this initialization to "0", the compiler will do that for you.
• Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG
• Make "getDoubleOrDefault" a "static" method.
• Remove this use of "java.io.FileReader"
• Remove this use of constructor "FileReader(File)"
• Remove this use of "java.io.FileReader"
• Make this line start at column 9.
• Make this line start at column 13.
• Make this line start at column 13.
• Make this line start at column 17.
• Make this line start at column 9.
• Make this line start at column 9.
• Make this line start at column 13.
• Make this line start at column 13.
• Complete the task associated to this TODO comment.
• Complete the task associated to this TODO comment.
• Complete the task associated to this TODO comment.
• Complete the task associated to this TODO comment.