-
- Downloads
There was an error fetching the commit references. Please try again later.
Revert deletion of some classes
Showing with 118 additions and 0 deletions
- src/input/BroadcastEventGenerator.java +40 -0 40 additions, 0 deletionssrc/input/BroadcastEventGenerator.java
- src/test/AbstractMessageEventGeneratorTest.java +35 -0 35 additions, 0 deletionssrc/test/AbstractMessageEventGeneratorTest.java
- src/test/BroadcastEventGeneratorTest.java +43 -0 43 additions, 0 deletionssrc/test/BroadcastEventGeneratorTest.java
Loading
-
Contributor
SonarQube analysis reported 93 issues:
Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this commit:
-
Add some tests to this class.
-
Add some tests to this class.
-
Add some tests to this class.
-
Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.
-
The Cyclomatic Complexity of this method "MessageEventGenerator" is 11 which is greater than 10 authorized.
-
Change this comparison to use the equals method.
-
Change this comparison to use the equals method.
-
Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.
-
Remove this unused private "drawEventRange" method.
-
Assign this magic number 2 to a well-named constant, and use the constant instead.
-
Assign this magic number 2 to a well-named constant, and use the constant instead.
-
Assign this magic number 2 to a well-named constant, and use the constant instead.
-
Assign this magic number 2 to a well-named constant, and use the constant instead.
-
Convert this usage of the ternary operator to an "if"/"else" structure.
-
Convert this usage of the ternary operator to an "if"/"else" structure.
-
Convert this usage of the ternary operator to an "if"/"else" structure.
-
Convert this usage of the ternary operator to an "if"/"else" structure.
-
Assign this magic number 2 to a well-named constant, and use the constant instead.
-
Assign this magic number 2 to a well-named constant, and use the constant instead.
-
Assign this magic number 2 to a well-named constant, and use the constant instead.
-
Catch a list of specific exception subtypes instead.
-
Remove the usage of the checked exception 'IOException'.
-
Catch a list of specific exception subtypes instead.
-
Either log or rethrow this exception.
-
This block of commented-out lines of code should be removed.
-
This block of commented-out lines of code should be removed.
-
This block of commented-out lines of code should be removed.
-
This block of commented-out lines of code should be removed.
-
This block of commented-out lines of code should be removed.
-
Assign this magic number 0.01 to a well-named constant, and use the constant instead.
-
Make this line start at column 9.
-
Make this line start at column 9.
-
Make this line start at column 17.
-
Remove this duplicated import.
-
Remove this duplicated import.
-
Make this line start at column 13.
-
Make this line start at column 9.
-
Make this line start at column 9.
-
Remove this duplicated import.
-
Remove this duplicated import.
-
Remove this duplicated import.
-
Remove this duplicated import.
-
Remove this duplicated import.
-
Replace all tab characters in this file by sequences of white-spaces.
-
Move this "else" on the same line that the previous closing curly brace.
-
Make this line start at column 13.
-
Move this "else" on the same line that the previous closing curly brace.
-
Move this "else" on the same line that the previous closing curly brace.
-
Move this "else" on the same line that the previous closing curly brace.
-
Move this "else" on the same line that the previous closing curly brace.
-
Move the array designator from the variable to the type.
-
Make this line start at column 5.
-
Make this line start at column 9.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 17.
-
Make this line start at column 17.
-
Make this line start at column 9.
-
Make this line start at column 13.
-
Make this line start at column 9.
-
Make this line start at column 9.
-
Make this line start at column 9.
-
Make this line start at column 13.
-
Make this line start at column 9.
-
Make this line start at column 13.
-
Make this line start at column 9.
-
Make this line start at column 9.
-
Remove this initialization to "0", the compiler will do that for you.
-
Remove this initialization to "0", the compiler will do that for you.
-
Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG
-
Make "getDoubleOrDefault" a "static" method.
-
Remove this use of "java.io.FileReader"
-
Remove this use of constructor "FileReader(File)"
-
Remove this use of "java.io.FileReader"
-
Make this line start at column 9.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Make this line start at column 17.
-
Make this line start at column 9.
-
Make this line start at column 9.
-
Make this line start at column 13.
-
Make this line start at column 13.
-
Complete the task associated to this TODO comment.
-
Complete the task associated to this TODO comment.
-
Complete the task associated to this TODO comment.
-
Complete the task associated to this TODO comment.
SonarQube analysis reported 93 issues: *  3 blocker *  2 critical *  25 major *  59 minor *  4 info Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this commit: *  [Add some tests to this class.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/test/EpidemicRouterTest.java#L16) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS2187) *  [Add some tests to this class.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/test/MaxPropRouterTest.java#L16) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS2187) *  [Add some tests to this class.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/test/ProphetRouterTest.java#L14) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS2187) *  [Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/core/SimScenario.java#L322) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS3776) *  [The Cyclomatic Complexity of this method "MessageEventGenerator" is 11 which is greater than 10 authorized.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L82) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity) *  [Change this comparison to use the equals method.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/SimMenuBar.java#L216) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1698) *  [Change this comparison to use the equals method.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/SimMenuBar.java#L217) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1698) *  [Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 21 to the maximum authorized 20 or less.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L42) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1200) *  [Remove this unused private "drawEventRange" method.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/VhmEventGraphic.java#L98) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUnusedPrivateMethod) *  [Assign this magic number 2 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/VhmEventGraphic.java#L88) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Assign this magic number 2 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/VhmEventGraphic.java#L88) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Assign this magic number 2 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/VhmEventGraphic.java#L100) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Assign this magic number 2 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/VhmEventGraphic.java#L101) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Convert this usage of the ternary operator to an "if"/"else" structure.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L137) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1774) *  [Convert this usage of the ternary operator to an "if"/"else" structure.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L139) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1774) *  [Convert this usage of the ternary operator to an "if"/"else" structure.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L161) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1774) *  [Convert this usage of the ternary operator to an "if"/"else" structure.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L171) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1774) *  [Assign this magic number 2 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L85) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Assign this magic number 2 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L89) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Assign this magic number 2 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L121) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Catch a list of specific exception subtypes instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEvent.java#L187) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS2221) *  [Remove the usage of the checked exception 'IOException'.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEvent.java#L188) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1162) *  [Catch a list of specific exception subtypes instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEventReader.java#L86) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS2221) *  [Either log or rethrow this exception.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEventReader.java#L86) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1166) *  [This block of commented-out lines of code should be removed.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L189) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ACommentedOutCodeLine) *  [This block of commented-out lines of code should be removed.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L234) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ACommentedOutCodeLine) *  [This block of commented-out lines of code should be removed.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L261) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ACommentedOutCodeLine) *  [This block of commented-out lines of code should be removed.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L556) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ACommentedOutCodeLine) *  [This block of commented-out lines of code should be removed.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L613) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ACommentedOutCodeLine) *  [Assign this magic number 0.01 to a well-named constant, and use the constant instead.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/routing/ActiveRouter.java#L76) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS109) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/core/DTNHost.java#L151) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/core/DTNHost.java#L455) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 17.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/core/SimScenario.java#L392) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Remove this duplicated import.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/SimMenuBar.java#L29) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUselessImportCheck) *  [Remove this duplicated import.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/SimMenuBar.java#L30) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUselessImportCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L224) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L347) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L352) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Remove this duplicated import.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L32) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUselessImportCheck) *  [Remove this duplicated import.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L33) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUselessImportCheck) *  [Remove this duplicated import.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L34) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUselessImportCheck) *  [Remove this duplicated import.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L35) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUselessImportCheck) *  [Remove this duplicated import.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/PlayField.java#L36) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AUselessImportCheck) *  [Replace all tab characters in this file by sequences of white-spaces.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/gui/playfield/VhmEventGraphic.java) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS00105) *  [Move this "else" on the same line that the previous closing curly brace.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/ExternalEventsQueue.java#L83) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ARightCurlyBraceSameLineAsNextBlockCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/ExternalEventsQueue.java#L84) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Move this "else" on the same line that the previous closing curly brace.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L91) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ARightCurlyBraceSameLineAsNextBlockCheck) *  [Move this "else" on the same line that the previous closing curly brace.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L109) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ARightCurlyBraceSameLineAsNextBlockCheck) *  [Move this "else" on the same line that the previous closing curly brace.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L116) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ARightCurlyBraceSameLineAsNextBlockCheck) *  [Move this "else" on the same line that the previous closing curly brace.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L126) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3ARightCurlyBraceSameLineAsNextBlockCheck) *  [Move the array designator from the variable to the type.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L149) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1197) *  [Make this line start at column 5.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L22) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L83) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L89) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L92) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L95) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L98) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L107) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L110) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L113) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L117) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L122) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 17.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L123) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 17.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L131) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L150) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L151) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L161) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L171) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L184) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L186) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L207) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L244) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L255) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L263) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Remove this initialization to "0", the compiler will do that for you.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L55) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS3052) *  [Remove this initialization to "0", the compiler will do that for you.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L61) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS3052) *  [Use a cryptographically strong random number generator (RNG) like "java.security.SecureRandom" in place of this PRNG](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/MessageEventGenerator.java#L103) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS2245) *  [Make "getDoubleOrDefault" a "static" method.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEvent.java#L230) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS2325) *  [Remove this use of "java.io.FileReader"](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEventReader.java#L46) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1943) *  [Remove this use of constructor "FileReader(File)"](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEventReader.java#L63) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1943) *  [Remove this use of "java.io.FileReader"](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/input/VhmEventReader.java#L79) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1943) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/map/SimMap.java#L72) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/map/SimMap.java#L74) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/map/SimMap.java#L79) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 17.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/map/SimMap.java#L80) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/routing/ActiveRouter.java#L96) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 9.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/routing/ActiveRouter.java#L103) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/routing/ActiveRouter.java#L104) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Make this line start at column 13.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/routing/ActiveRouter.java#L613) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AIndentationCheck) *  [Complete the task associated to this TODO comment.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L30) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1135) *  [Complete the task associated to this TODO comment.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L201) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1135) *  [Complete the task associated to this TODO comment.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L561) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1135) *  [Complete the task associated to this TODO comment.](https://git.cs.upb.de/pg-andi/Simulator/blob/87e1b7cef802bf4ebdcf091e5bb074ac5d63460c/src/movement/VoluntaryHelperMovement.java#L612) [](http://pg-andi-redmine.cs.upb.de:9000/coding_rules#rule_key=squid%3AS1135) -
Please register or sign in to comment