🐛 fixed character length in database model

alembic/versions/bed1aefe514f_overflow_fix.py

+"""overflow fix
+
+Revision ID: bed1aefe514f
+Revises: 278aca658ba6
+Create Date: 2022-01-26 11:52:48.248018
+
+"""
+from alembic import op
+import sqlalchemy as sa
+
+
+# revision identifiers, used by Alembic.
+revision = 'bed1aefe514f'
+down_revision = '278aca658ba6'
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column('appointment', 'room',
+               existing_type=sa.VARCHAR(length=64),
+               type_=sa.VARCHAR(length=128),
+               existing_nullable=False)
+    op.alter_column('appointment', 'instructors',
+               existing_type=sa.VARCHAR(length=128),
+               type_=sa.VARCHAR(length=256),
+               existing_nullable=False)
+    op.alter_column('course', 'name',
+               existing_type=sa.VARCHAR(length=64),
+               type_=sa.VARCHAR(length=256),
+               existing_nullable=False)
+    op.alter_column('small_group', 'name',
+               existing_type=sa.VARCHAR(length=64),
+               type_=sa.VARCHAR(length=128),
+               existing_nullable=False)
+    # ### end Alembic commands ###
+
+
+def downgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column('small_group', 'name',
+               existing_type=sa.VARCHAR(length=128),
+               type_=sa.VARCHAR(length=64),
+               existing_nullable=False)
+    op.alter_column('course', 'name',
+               existing_type=sa.VARCHAR(length=256),
+               type_=sa.VARCHAR(length=64),
+               existing_nullable=False)
+    op.alter_column('appointment', 'instructors',
+               existing_type=sa.VARCHAR(length=256),
+               type_=sa.VARCHAR(length=128),
+               existing_nullable=False)
+    op.alter_column('appointment', 'room',
+               existing_type=sa.VARCHAR(length=128),
+               type_=sa.VARCHAR(length=64),
+               existing_nullable=False)
+    # ### end Alembic commands ###

app/data/storage/models/course.py

@@ -29,15 +29,15 @@ class Appointment(Base):
     id = Column(Integer, primary_key=True, autoincrement=True)
     start_time = Column(DateTime, nullable=False)
     end_time = Column(DateTime, nullable=False)
-    room = Column(VARCHAR(64), nullable=False)
-    instructors = Column(VARCHAR(128), nullable=False)
+    room = Column(VARCHAR(128), nullable=False)
+    instructors = Column(VARCHAR(256), nullable=False)
 
 
 class SmallGroup(Base):
     __tablename__ = 'small_group'
 
     id = Column(Integer, primary_key=True, autoincrement=True)
-    name = Column(VARCHAR(64), nullable=False)
+    name = Column(VARCHAR(128), nullable=False)
 
     course_id = Column(Integer, ForeignKey('course.id'))
     course = relationship("Course", back_populates="small_groups")
@@ -50,7 +50,7 @@ class Course(Base):
 
     id = Column(Integer, primary_key=True, autoincrement=True)
     cid = Column(VARCHAR(32), nullable=False)
-    name = Column(VARCHAR(64), nullable=False)
+    name = Column(VARCHAR(256), nullable=False)
     description = Column(VARCHAR(255), nullable=True)
 
     small_groups = relationship("SmallGroup", back_populates="course")

app/scraper/paul.py

@@ -69,7 +69,7 @@ def __parse_appointment(soup: BeautifulSoup) -> List[schemas.Appointment]:
                 appointments.append(schemas.Appointment(
                     start_time=parse_date(columns[1], columns[2]),
                     end_time=parse_date(columns[1], columns[3]),
-                    room=columns[4],
+                    room=' '.join(columns[4].split()),
                     instructors=columns[5]
                 ))